Skip to content

Conversation

@leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Oct 10, 2025

Requires #2564

Starting work on #2452

We have a testcase class that should be subclassed by individual tests.

Each test then should provide a main function that will run its testcase.

Lmk what you think, any feedback, etc. is very much appreciated :)

The tests are currently only run for the "build" CI should they be run for the others too?

@leolost2605 leolost2605 changed the title Leolost/introduce simple test Introduce a first simple test Oct 10, 2025
@leolost2605 leolost2605 force-pushed the leolost/introduce-simple-test branch 3 times, most recently from f4094ed to a16e304 Compare October 10, 2025 14:17
@leolost2605 leolost2605 force-pushed the leolost/introduce-simple-test branch from a16e304 to 23a4137 Compare October 11, 2025 16:41
@leolost2605 leolost2605 force-pushed the leolost/introduce-simple-test branch from 23a4137 to 82a35a6 Compare October 11, 2025 16:45
@leolost2605 leolost2605 marked this pull request as ready for review October 11, 2025 16:46
@leolost2605 leolost2605 requested a review from lenemter October 11, 2025 16:47
Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leolost2605
Copy link
Member Author

@danirabbit since the build job now also runs the tests I renamed it to build-and-test. Would you prefer changing it back to build or can you update repository rules to require build-and-test instead of build?

@leolost2605
Copy link
Member Author

@danirabbit slight reping :)

@danirabbit
Copy link
Member

Oops thanks for pinging me again. I can update the rules 🚀

@danirabbit danirabbit merged commit cec55d9 into main Oct 29, 2025
6 checks passed
@danirabbit danirabbit deleted the leolost/introduce-simple-test branch October 29, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants